summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2011-02-21 18:39:45 +0000
committerBen Hutchings <bhutchings@solarflare.com>2011-02-21 18:53:20 +0000
commitd3265b44a204f793400638e7a07b932c78a89bbd (patch)
tree555e194fa7e1b6c2a6ddb5ae6d2dbb886f6eabab
parent97a8e6adee88a8a0b110f514638cc71124963996 (diff)
downloadethtool-d3265b44a204f793400638e7a07b932c78a89bbd.tar.gz
ethtool: Report an error if given an unrecognised option
Previously we would print full usage information and return 0. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
-rw-r--r--ethtool.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/ethtool.c b/ethtool.c
index b9422d3..d28f1b2 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -807,10 +807,11 @@ static void parse_cmdline(int argc, char **argp)
mode = args[k].Mode;
break;
}
- if (mode == MODE_HELP ||
- (!args[k].srt && argp[i][0] == '-')) {
+ if (mode == MODE_HELP) {
show_usage();
exit(0);
+ } else if (!args[k].srt && argp[i][0] == '-') {
+ exit_bad_args();
} else {
devname = argp[i];
}