summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-07-01Ethtool: Free memory leak in do_sprivflags()Yuval Mintz1-0/+1
cmdline is allocated for usage in parse_generic_cmdline(), but is not released after its final usage. Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-07-01Ethtool: Beautify private flags printYuval Mintz1-1/+11
When printing the private flags of the device, align all strings to have the same length. Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com> [bwh: Fix indentation] Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-04-30Release version 3.9.Ben Hutchings2-1/+7
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-04-30ixgbe: check mac type from ethtool_regs.versionBen Hutchings1-2/+5
This patch cleans up the mac type checks by using ethtool_regs.version provided by the driver. This change eliminates the need to add device IDs every time they are added to the driver. Note that when using ethtool with this patch with a version of ixgbe that does not provide the mac_type in ethtool_regs.version the register dump may be incomplete. However this issue would've existed previously for device IDs that were not added to ethtool. Original patch and description by Emil Tantilov <emil.s.tantilov@intel.com>. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-03-21ethtool: Add string to display support for KR PHYVasundhara, Volam1-0/+1
Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-02-28Release version 3.8.Ben Hutchings2-1/+10
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-02-28Restore 20000baseKR2 cap displayYaniv Rosner1-0/+1
Restore the 20000baseKR2 which was removed by mistake back in June 2012. Signed-off-by: Yaniv Rosner <yanivr@broadcom.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-02-07ethtool.8: Correct minor formatting errorsBen Hutchings1-6/+3
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-02-07ethtool.8: Fix reference to nonexistent l4m keyword for flow specsBen Hutchings1-1/+1
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-02-07ethtool.8: Clarify explanation of flow spec mask keywordsBen Hutchings1-3/+4
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-02-07ethtool.8: Show ethtool -s speed keyword as optional, matching implementationBen Hutchings1-1/+1
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-02-07ethtool.8: Improve description of --test optionBen Hutchings1-5/+7
There were numerous grammatical errors in these descriptions, combined with poor formatting. Describe each mode under a separate heading. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-02-07ethtool.8: Improve description of --flash optionBen Hutchings1-6/+13
Avoid repeating 'flash' as a verb; that doesn't explain anything. For consistency, describe both parameters (aside from devname) under separate headings, formatted as lower-case italic. Explain how the filename is resolved. Explain what non-zero values of N would mean, and that they are driver-dependent. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-01-22ethtool: Fix space-after-if checkpatch errorsMark Einon3-3/+3
Some version check statements are lacking a space after the if () statement. Add them in. Signed-off-by: Mark Einon <mark.einon@gmail.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-01-22ethtool: Add version check for et131x regsMark Einon1-0/+4
Added a version check for the et131x reg dump, in case the dump format needs to be changed later. Signed-off-by: Mark Einon <mark.einon@gmail.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-01-22rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext()Ben Hutchings1-1/+1
Previously only the lower 32 bits would be shown. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-01-22Added dst-mac parameter for L3/L4 flow spec rules. This is usefull in ↵Yan Burman3-19/+54
vSwitch configurations. Signed-off-by: Yan Burman <yanb@mellanox.com> Signed-off-by: Amir Vadai <amirv@mellanox.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2013-01-22ethtool-copy.h: sync with netBen Hutchings1-5/+20
This covers kernel changes up to: commit dc2e57340deb8be1133b1eae2c7d4303133c133c Author: Yan Burman <yanb@mellanox.com> Date: Thu Dec 13 05:20:59 2012 +0000 net: ethool: Document struct ethtool_flow_ext Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-12-13Release version 3.7.Ben Hutchings3-2/+8
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-12-03Implemented basic optics diagnostics for SFF-8472Aurelien Guillaume7-19/+404
The current output of -m has been modified so that everything lines up correctly. The --module-info option alias has been added. Signed-off-by: Aurelien Guillaume <aurelien@iwi.me> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-11-08ethtool: Support et131x registers in -dMark Einon4-1/+124
The et131x register set contains useful details of RX/TX queues for the device. This dumps them with the -d option. Signed-off-by: Mark Einon <mark.einon@gmail.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-10-10Gracefully handle failure of register dump pretty-printerBen Hutchings1-3/+10
If we have a pretty-printer matching the driver name for a register dump, but it doesn't handle the reported dump version, then we currently fail and print: Cannot dump registers: Success Instead, fall back to hex dump. Also, don't use perror() to explain a failure of dump_regs(). errno is not meaningful in either failure case. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-10-05Release version 3.6.Ben Hutchings3-2/+10
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-10-05ethtool: --set-eee sends ETHTOOL_SEEE ioctl even if nothing changedBruce Allan1-1/+1
When setting EEE parameters with the --set-eee command line option, ethtool will send the ETHTOOL_SEEE ioctl down to the driver even if none of the provided parameters are a change from current settings. Simply ignore it when that happens as done with other ethtool commands. Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-09-06ethtool: don't overwrite useful bits in advertising bitfieldJohan Gunnarsson1-14/+77
There are bits in this bitfield that we want to leave untouched (PAUSE and ASYM_PAUSE bits) when changing other bits (speed and duplex bits.) Previously, these were always overwritten to zero when running commands like "ethtool -s eth0 speed 10 duplex full autoneg off". Signed-off-by: Johan Gunnarsson <johangu@axis.com> [bwh: Fixed spelling and formatting] Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-09-06test-cmdline: Test -s mdix keywordBen Hutchings1-1/+3
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-09-06ethtool.8: Mark-up mdix arguments properlyBen Hutchings1-5/+6
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-09-06ethtool: allow setting MDI-X stateJesse Brandeburg2-10/+53
A bit ago ethtool added support for reading MDI-X state, this patch finishes the implementation, adding the complementary write command. Add support to ethtool for controlling the MDI-X (crossover) state of a network port. Most adapters correctly negotiate MDI-X, but some ill-behaved switches have trouble and end up picking the wrong MDI setting, which results in complete loss of link. Usually this error condition can be observed when multiple ethtool -r ethX are required before link is achieved. This patch allows the user to override the normal "auto" setting and force the crossover state to on or off. The set will fail if the driver doesn't support the get, as suggested by Ben Hutchings. setting MDI not supported In addition the do_gset output was changed slightly to report the value set by the user (when the driver supports the set) old: MDI-X: on new: MDI-X: on (auto) or MDI-X: on (forced) usage is ethtool -s eth0 mdix [auto|on|off] Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> CC: Ben Hutchings <bhutchings@solarflare.com> Tested-by: Aaron Brown aaron.f.brown@intel.com Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-09-06ethtool-copy.h: sync with net-nextBen Hutchings1-6/+11
This covers kernel changes up to: commit 6f6bbc186dc8e4e0c628db7decbd1a5e02cb5fd8 Author: Jesse Brandeburg <jesse.brandeburg@intel.com> Date: Thu Jul 26 02:30:53 2012 +0000 ethtool.h: MDI setting support Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-09-06Merge commit 'v3.5'Ben Hutchings1-1/+1
I tagged v3.5 and pushed out master in the middle of rebasing master to add the last fix for 3.5. Conflicts: NEWS
2012-08-03Release version 3.5.Ben Hutchings2-1/+11
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-08-03ethtool.8: Correct full name of EEEBen Hutchings1-1/+1
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-08-03ethtool.8: Correct full name of EEEBen Hutchings1-1/+1
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-08-02Release version 3.5.Ben Hutchings2-1/+11
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-17ethtool.spec: Do not include ChangeLog or INSTALLBen Hutchings1-1/+1
The ChangeLog is ancient history, replaced by the version control changelog. INSTALL is redundant in a binary package. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-17ethtool.spec: Update URL to the current home pageBen Hutchings1-1/+1
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-17ethtool.spec: Update summary and description, based on Fedora packageBen Hutchings1-6/+4
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16Merge commit 'v3.4.2'Ben Hutchings4-28/+85
2012-07-16ethtool: added support for 40G link.Parav Pandit1-0/+4
1. defined values for KR4, CR4, SR4, LR4 PHY. Signed-off-by: Parav Pandit <parav.pandit@emulex.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16ethtool-copy.h: sync with net-nextBen Hutchings1-0/+8
This covers kernel changes up to: commit e440cf2ca0a1b075c64016240d46c3aa9d877bbf Author: parav.pandit@emulex.com <parav.pandit@emulex.com> Date: Wed Jun 27 03:56:12 2012 +0000 net: added support for 40GbE link. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16Don't trust drivers to null-terminate stringsBen Hutchings1-15/+23
Some drivers have been seen to fill all bytes of ethtool_drvinfo::fw_version without including a null terminator, which effectively concatenates the following bytes to the string. We've already dealt with a similar problem in dump_stats() (commit 7764430a139e4a089127f5616b0d56f497be1036). Try to cover all the remaining string fields: - In dump_drvinfo(), limit the length using printf() modifiers - Add an option to get_stringset() to null-terminate all strings - Change all callers except dump_stats() to set that option Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16test-cmdline: More test cases for EEE optionsBen Hutchings1-0/+4
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16Ethtool: Add EEE supportYuval Mintz3-20/+159
This patch adds 2 new ethtool commands which can be used to manipulate network interfaces' support in EEE. Output of 'get' has the following form: EEE Settings for p2p1: EEE status: enabled - active Tx LPI: 1000 (us) Supported EEE link modes: 10000baseT/Full Advertised EEE link modes: 10000baseT/Full Link partner advertised EEE link modes: 10000baseT/Full Thanks goes to Giuseppe Cavallaro for his original patch. Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com> Signed-off-by: Eilon Greenstein <eilong@broadcom.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16Release version 3.4.2.Ben Hutchings2-1/+10
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16Fix reporting of VLAN tag offload flags on Linux < 2.6.37Ben Hutchings1-0/+41
These kernel versions implement ETHTOOL_GFLAGS but do not include the flags for VLAN tag offload (and do not implement ETHTOOL_GFEATURES). Since the VLAN tag offload features were already defined and implemented by many drivers, we shouldn't assume they are off. Instead, since these feature flag values were stable, read them from sysfs. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16Remove bogus error message when changing offload settings on Linux < 2.6.39Ben Hutchings1-27/+33
We should not be checking for fixed features when we have no information about which are fixed. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-07-16ethtool: Resolve use of uninitialized memory in rxclass_get_dev_infoAlexander Duyck1-0/+1
The ethtool function for getting the rule count was not zeroing out the data field before passing it to the kernel. As a result the value started uninitialized and was incorrectly returning a result indicating that devices supported setting new rule indexes. In order to correct this I am adding a one line fix that sets data to zero before we pass the command to the kernel. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-06-13Merge commit 'v3.4.1'Ben Hutchings5-4/+48
2012-06-13Release version 3.4.1.Ben Hutchings2-1/+9
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
2012-06-13ethtool.8: Fix the dateBen Hutchings1-1/+1
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
generated by cgit v1.2.1 (git 2.18.0) at 2024-04-18 15:42:06 +0000