From be76a4529148c2790f53ccc8e879b4cc6b34b6b9 Mon Sep 17 00:00:00 2001 From: Ben Hutchings Date: Thu, 27 Oct 2011 19:11:35 +0100 Subject: Fix type of bit-number parameter to set_bit() and clear_bit() The index must not be negative, so the parameter does not need to be signed. Division and modulus on signed operands generally cannot be optimised to right-shift and bitwise-and. Signed-off-by: Ben Hutchings --- internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal.h b/internal.h index 693b091..2b6a54a 100644 --- a/internal.h +++ b/internal.h @@ -62,12 +62,12 @@ static inline u64 cpu_to_be64(u64 value) #define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) #define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_LONG) -static inline void set_bit(int nr, unsigned long *addr) +static inline void set_bit(unsigned int nr, unsigned long *addr) { addr[nr / BITS_PER_LONG] |= 1UL << (nr % BITS_PER_LONG); } -static inline void clear_bit(int nr, unsigned long *addr) +static inline void clear_bit(unsigned int nr, unsigned long *addr) { addr[nr / BITS_PER_LONG] &= ~(1UL << (nr % BITS_PER_LONG)); } -- cgit v1.2.1