From d3265b44a204f793400638e7a07b932c78a89bbd Mon Sep 17 00:00:00 2001 From: Ben Hutchings Date: Mon, 21 Feb 2011 18:39:45 +0000 Subject: ethtool: Report an error if given an unrecognised option Previously we would print full usage information and return 0. Signed-off-by: Ben Hutchings --- ethtool.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ethtool.c b/ethtool.c index b9422d3..d28f1b2 100644 --- a/ethtool.c +++ b/ethtool.c @@ -807,10 +807,11 @@ static void parse_cmdline(int argc, char **argp) mode = args[k].Mode; break; } - if (mode == MODE_HELP || - (!args[k].srt && argp[i][0] == '-')) { + if (mode == MODE_HELP) { show_usage(); exit(0); + } else if (!args[k].srt && argp[i][0] == '-') { + exit_bad_args(); } else { devname = argp[i]; } -- cgit v1.2.1