Minor char * to unsigned char* changes. The general rule is to use

unsigned char * for memory buffers which are not Nul-terminated

2 files changed, 8 insertions, 5 deletions

diff --git a/mpi/ChangeLog b/mpi/ChangeLog
index 87161f9e..b2701607 100644
--- a/mpi/ChangeLog
+++ b/mpi/ChangeLog
@@ -1,12 +1,13 @@
 2003-07-27  Werner Koch  <wk@gnupg.org>
 
 	* mpicoder.c (gcry_mpi_scan): New argument BUFLEN to replace the
-	use of the intial value of NBYTES.
+	use of the intial value of NBYTES.  Changed BUFFER to unsigned.
 	(gcry_mpi_print): Likewise.
 	(gcry_mpi_dump): New.
 	(_gcry_log_mpidump): Make use of gcry_mpi_dump.
 	(mpi_print): Removed.
 	(gcry_mpi_scan): Allocated mpi in secure memory when required.
+	(gcry_mpi_aprint): Changed BUFFER to unsigned char*.
 
 2003-07-14  Moritz Schulte  <moritz@g10code.com>
 
diff --git a/mpi/mpicoder.c b/mpi/mpicoder.c
index fa390920..d501fe4b 100644
--- a/mpi/mpicoder.c
+++ b/mpi/mpicoder.c
@@ -333,7 +333,7 @@ _gcry_mpi_set_buffer( gcry_mpi_t a, const byte *buffer, unsigned nbytes, int sig
    bytes actually scanned after a successful operation. */
 gcry_error_t
 gcry_mpi_scan( struct gcry_mpi **ret_mpi, enum gcry_mpi_format format,
-		const char *buffer, size_t buflen, size_t *nscanned )
+		const unsigned char *buffer, size_t buflen, size_t *nscanned )
 {
     struct gcry_mpi *a = NULL;
     unsigned int len;
@@ -458,7 +458,8 @@ gcry_mpi_scan( struct gcry_mpi **ret_mpi, enum gcry_mpi_format format,
    has been passed as NULL.  BUFFER may be NULL to query the required
    length.*/
 gcry_error_t
-gcry_mpi_print( enum gcry_mpi_format format, char *buffer, size_t buflen,
+gcry_mpi_print( enum gcry_mpi_format format,
+                unsigned char *buffer, size_t buflen,
                 size_t *nwritten, struct gcry_mpi *a)
 {
     unsigned int nbits = mpi_get_nbits(a);
@@ -600,7 +601,7 @@ gcry_mpi_print( enum gcry_mpi_format format, char *buffer, size_t buflen,
 		*s++ = c < 10? '0'+c : 'A'+c-10 ;
 	    }
 	    *s++ = 0;
-	    *nwritten = (char*)s - buffer;
+	    *nwritten = s - buffer;
 	}
 	else {
 	    *nwritten = 2*n + extra + !!a->sign + 1;
@@ -618,7 +619,8 @@ gcry_mpi_print( enum gcry_mpi_format format, char *buffer, size_t buflen,
  * NULL.
  */
 gcry_error_t
-gcry_mpi_aprint( enum gcry_mpi_format format, void **buffer, size_t *nwritten,
+gcry_mpi_aprint( enum gcry_mpi_format format,
+                 unsigned char **buffer, size_t *nwritten,
 		 struct gcry_mpi *a )
 {
     size_t n;