From 592c2ab3deeeccbb6d3b078ed7bf0e6627c8e1fb Mon Sep 17 00:00:00 2001 From: Jussi Kivilinna Date: Sat, 21 Sep 2013 13:54:38 +0300 Subject: Use hash transform function return type for passing burn stack depth * cipher/gostr4311-94.c (transform): Return stack burn depth. * cipher/hash-common.c (_gcry_md_block_write): Use stack burn depth returned by 'hd->bwrite'. * cipher/hash-common.h (_gcry_md_block_write_t): Change return type to 'unsigned int'. (gry_md_block_ctx_t): Remove 'stack_burn'. * cipher/md4.c (transform): Return stack burn depth. (md4_final): Use stack burn depth from transform. * cipher/md5.c (transform): Return stack burn depth. (md5_final): Use stack burn depth from transform. * cipher/rmd160.c (transform): Return stack burn depth. (rmd160_final): Use stack burn depth from transform. * cipher/sha1.c (transform): Return stack burn depth. (sha1_final): Use stack burn depth from transform. * cipher/sha256.c (transform): Return stack burn depth. (sha256_final): Use stack burn depth from transform. * cipher/sha512.c (__transform, transform): Return stack burn depth. (sha512_final): Use stack burn depth from transform. * cipher/stribog.c (transform64): Return stack burn depth. * cipher/tiger.c (transform): Return stack burn depth. (tiger_final): Use stack burn depth from transform. -- Transform function might want different depth of stack burn depending on detected CPU features (like in SHA-512 on ARM with NEON). So return stack burn depth from transform functions as a request or a hint to calling function. Signed-off-by: Jussi Kivilinna --- cipher/md4.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'cipher/md4.c') diff --git a/cipher/md4.c b/cipher/md4.c index 9e75fbc5..2de530cc 100644 --- a/cipher/md4.c +++ b/cipher/md4.c @@ -64,7 +64,7 @@ typedef struct { u32 A,B,C,D; /* chaining variables */ } MD4_CONTEXT; -static void +static unsigned int transform ( void *c, const unsigned char *data ); static void @@ -80,7 +80,6 @@ md4_init( void *context ) ctx->bctx.nblocks = 0; ctx->bctx.count = 0; ctx->bctx.blocksize = 64; - ctx->bctx.stack_burn = 80+6*sizeof(void*); ctx->bctx.bwrite = transform; } @@ -92,7 +91,7 @@ md4_init( void *context ) /**************** * transform 64 bytes */ -static void +static unsigned int transform ( void *c, const unsigned char *data ) { MD4_CONTEXT *ctx = c; @@ -188,6 +187,8 @@ transform ( void *c, const unsigned char *data ) ctx->B += B; ctx->C += C; ctx->D += D; + + return /*burn_stack*/ 80+6*sizeof(void*); } @@ -204,6 +205,7 @@ md4_final( void *context ) MD4_CONTEXT *hd = context; u32 t, msb, lsb; byte *p; + unsigned int burn; _gcry_md_block_write(hd, NULL, 0); /* flush */; @@ -244,8 +246,8 @@ md4_final( void *context ) hd->bctx.buf[61] = msb >> 8; hd->bctx.buf[62] = msb >> 16; hd->bctx.buf[63] = msb >> 24; - transform( hd, hd->bctx.buf ); - _gcry_burn_stack (80+6*sizeof(void*)); + burn = transform( hd, hd->bctx.buf ); + _gcry_burn_stack (burn); p = hd->bctx.buf; #ifdef WORDS_BIGENDIAN -- cgit v1.2.1