summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Phlipot <cphlipot0@gmail.com>2016-05-10 20:26:47 -0700
committerArnaldo Carvalho de Melo <acme@redhat.com>2016-05-11 12:24:57 -0300
commitbd0a51dd2794f1d17d4e7a34ad66db845cef3e5a (patch)
tree61a50ff5d1915be8334beb22977afd56c9a2e9dc
parentae93a6c70838b87151ac12589dc507dbf4f2f067 (diff)
downloadlinux-bd0a51dd2794f1d17d4e7a34ad66db845cef3e5a.tar.gz
perf script: Fix symbol insertion behavior in db-export
Use the dso__insert_symbol function instead of symbols__insert() in order to properly update the dso symbol cache. If the cache is not updated, then duplicate symbols can be unintentionally created, inserted, and exported. This change prevents duplicate symbols from being exported due to dso__find_symbol() using a stale symbol cache. Signed-off-by: Chris Phlipot <cphlipot0@gmail.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1462937209-6032-3-git-send-email-cphlipot0@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/util/db-export.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c
index f8e3057ae3b1..2ef1f692c35b 100644
--- a/tools/perf/util/db-export.c
+++ b/tools/perf/util/db-export.c
@@ -260,8 +260,7 @@ static int db_ids_from_al(struct db_export *dbe, struct addr_location *al,
if (!al->sym) {
al->sym = symbol__new(al->addr, 0, 0, "unknown");
if (al->sym)
- symbols__insert(&dso->symbols[al->map->type],
- al->sym);
+ dso__insert_symbol(dso, al->map->type, al->sym);
}
if (al->sym) {