path: root/arch/cris/arch-v10/Kconfig
diff options
authorPetr Mladek <>2016-05-20 17:00:33 -0700
committerLinus Torvalds <>2016-05-20 17:58:30 -0700
commit42a0bb3f71383b457a7db362f1c69e7afb96732b (patch)
treec63f12bed74fee20662fbcc8cc985d53a0d20def /arch/cris/arch-v10/Kconfig
parent2eeed7e98d6a1341b1574893a95ce5b8379140f2 (diff)
printk/nmi: generic solution for safe printk in NMI
printk() takes some locks and could not be used a safe way in NMI context. The chance of a deadlock is real especially when printing stacks from all CPUs. This particular problem has been addressed on x86 by the commit a9edc8809328 ("x86/nmi: Perform a safe NMI stack trace on all CPUs"). The patchset brings two big advantages. First, it makes the NMI backtraces safe on all architectures for free. Second, it makes all NMI messages almost safe on all architectures (the temporary buffer is limited. We still should keep the number of messages in NMI context at minimum). Note that there already are several messages printed in NMI context: WARN_ON(in_nmi()), BUG_ON(in_nmi()), anything being printed out from MCE handlers. These are not easy to avoid. This patch reuses most of the code and makes it generic. It is useful for all messages and architectures that support NMI. The alternative printk_func is set when entering and is reseted when leaving NMI context. It queues IRQ work to copy the messages into the main ring buffer in a safe context. __printk_nmi_flush() copies all available messages and reset the buffer. Then we could use a simple cmpxchg operations to get synchronized with writers. There is also used a spinlock to get synchronized with other flushers. We do not longer use seq_buf because it depends on external lock. It would be hard to make all supported operations safe for a lockless use. It would be confusing and error prone to make only some operations safe. The code is put into separate printk/nmi.c as suggested by Steven Rostedt. It needs a per-CPU buffer and is compiled only on architectures that call nmi_enter(). This is achieved by the new HAVE_NMI Kconfig flag. The are MN10300 and Xtensa architectures. We need to clean up NMI handling there first. Let's do it separately. The patch is heavily based on the draft from Peter Zijlstra, see [ printk-nmi: use %zu format string for size_t] [ min_t->min - all types are size_t here] Signed-off-by: Petr Mladek <> Suggested-by: Peter Zijlstra <> Suggested-by: Steven Rostedt <> Cc: Jan Kara <> Acked-by: Russell King <> [arm part] Cc: Daniel Thompson <> Cc: Jiri Kosina <> Cc: Ingo Molnar <> Cc: Thomas Gleixner <> Cc: Ralf Baechle <> Cc: Benjamin Herrenschmidt <> Cc: Martin Schwidefsky <> Cc: David Miller <> Cc: Daniel Thompson <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'arch/cris/arch-v10/Kconfig')
0 files changed, 0 insertions, 0 deletions