path: root/arch/cris/arch-v10
diff options
authorPaul Gortmaker <>2015-06-14 16:55:25 -0400
committerPaul Gortmaker <>2015-06-16 14:12:31 -0400
commit84c3e5bf1defc035d63869bbb0f5f80d276c1fc7 (patch)
treee34470264028c5828a58ed72221cb33e11b3e0f3 /arch/cris/arch-v10
parent4d38e5c48f4095be21343869ad741676ab4e518f (diff)
cris: don't use module_init for non-modular core eeprom.c code
The eeprom.c code is compiled based on the Kconfig setting ETRAX_I2C_EEPROM, which is bool. So the code is either built in or absent. It will never be modular, so using module_init as an alias for __initcall is rather misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Direct use of __initcall is discouraged, vs prioritized ones. Use of device_initcall is consistent with what __initcall maps onto, and hence does not change the init order, making the impact of this change zero. Should someone with real hardware for boot testing want to change it later to arch_initcall or something different, they can do that at a later date. Cc: Mikael Starvik <> Cc: Jesper Nilsson <> Cc: Signed-off-by: Paul Gortmaker <>
Diffstat (limited to 'arch/cris/arch-v10')
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/cris/arch-v10/drivers/eeprom.c b/arch/cris/arch-v10/drivers/eeprom.c
index 5047a33043bd..f679a19dfeb8 100644
--- a/arch/cris/arch-v10/drivers/eeprom.c
+++ b/arch/cris/arch-v10/drivers/eeprom.c
@@ -848,5 +848,4 @@ static void eeprom_disable_write_protect(void)
/* Write protect disabled */