path: root/drivers/net
diff options
authorDavid Barroso <>2016-06-28 11:16:43 +0300
committerDavid S. Miller <>2016-06-29 07:58:28 -0400
commitb560f03ddfb072bca65e9440ff0dc4f9b1d1f056 (patch)
tree03bf25ae415a6a6a43e07d4ad739c1fbe5bd2582 /drivers/net
parent889ad4566604610804df984e1a3dd5e2c66256e5 (diff)
neigh: Explicitly declare RCU-bh read side critical section in neigh_xmit()
neigh_xmit() expects to be called inside an RCU-bh read side critical section, and while one of its two current callers gets this right, the other one doesn't. More specifically, neigh_xmit() has two callers, mpls_forward() and mpls_output(), and while both callers call neigh_xmit() under rcu_read_lock(), this provides sufficient protection for neigh_xmit() only in the case of mpls_forward(), as that is always called from softirq context and therefore doesn't need explicit BH protection, while mpls_output() can be called from process context with softirqs enabled. When mpls_output() is called from process context, with softirqs enabled, we can be preempted by a softirq at any time, and RCU-bh considers the completion of a softirq as signaling the end of any pending read-side critical sections, so if we do get a softirq while we are in the part of neigh_xmit() that expects to be run inside an RCU-bh read side critical section, we can end up with an unexpected RCU grace period running right in the middle of that critical section, making things go boom. This patch fixes this impedance mismatch in the callee, by making neigh_xmit() always take rcu_read_{,un}lock_bh() around the code that expects to be treated as an RCU-bh read side critical section, as this seems a safer option than fixing it in the callers. Fixes: 4fd3d7d9e868f ("neigh: Add helper function neigh_xmit") Signed-off-by: David Barroso <> Signed-off-by: Lennert Buytenhek <> Acked-by: David Ahern <> Acked-by: Robert Shearman <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions