path: root/kernel/irq
diff options
authorJon Hunter <>2016-05-10 16:14:35 +0100
committerMarc Zyngier <>2016-05-11 10:12:41 +0100
commit9b5d585d148a19bcadae81fa17ddbe3e22efb9e9 (patch)
tree9d601b1a9c094bc4bc96934443158d8f454a8463 /kernel/irq
parent7c9b973061b03af62734f613f6abec46c0dd4a88 (diff)
genirq: Ensure IRQ descriptor is valid when setting-up the IRQ
In the function, setup_irq(), we don't check that the descriptor returned from irq_to_desc() is valid before we start using it. For example chip_bus_lock() called from setup_irq(), assumes that the descriptor pointer is valid and doesn't check before dereferencing it. In many other functions including setup/free_percpu_irq() we do check that the descriptor returned is not NULL and therefore add the same test to setup_irq() to ensure the descriptor returned is valid. Signed-off-by: Jon Hunter <> Signed-off-by: Marc Zyngier <>
Diffstat (limited to 'kernel/irq')
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index cc1cc641d653..ef0bc02c3a70 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1407,7 +1407,7 @@ int setup_irq(unsigned int irq, struct irqaction *act)
int retval;
struct irq_desc *desc = irq_to_desc(irq);
- if (WARN_ON(irq_settings_is_per_cpu_devid(desc)))
+ if (!desc || WARN_ON(irq_settings_is_per_cpu_devid(desc)))
return -EINVAL;
retval = __setup_irq(irq, desc, act);