path: root/kernel
diff options
authorAlexei Starovoitov <>2016-06-15 18:25:39 -0700
committerDavid S. Miller <>2016-06-15 23:37:54 -0700
commitad572d174787daa59e24b8b5c83028c09cdb5ddb (patch)
tree742f85968aea27bc975164e839dbc00312d3184a /kernel
parent19de99f70b87fcc3338da52a89c439b088cbff71 (diff)
bpf, trace: check event type in bpf_perf_event_read
similar to bpf_perf_event_output() the bpf_perf_event_read() helper needs to check the type of the perf_event before reading the counter. Fixes: a43eec304259 ("bpf: introduce bpf_perf_event_output() helper") Reported-by: Daniel Borkmann <> Signed-off-by: Alexei Starovoitov <> Acked-by: Daniel Borkmann <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'kernel')
1 files changed, 4 insertions, 0 deletions
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index e7af6cb9d5cf..26f603da7e26 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -209,6 +209,10 @@ static u64 bpf_perf_event_read(u64 r1, u64 index, u64 r3, u64 r4, u64 r5)
return -EINVAL;
+ if (unlikely(event->attr.type != PERF_TYPE_HARDWARE &&
+ event->attr.type != PERF_TYPE_RAW))
+ return -EINVAL;
* we don't know if the function is run successfully by the
* return value. It can be judged in other places, such as