path: root/mm/mempool.c
diff options
authorSergey Senozhatsky <>2015-09-08 15:00:53 -0700
committerLinus Torvalds <>2015-09-08 15:35:28 -0700
commit4e3ca3e033d1eea62fa16c3fdbef4f20427bd0de (patch)
tree34ff5ce0159e781d1b8ca208ff827e53d37545a8 /mm/mempool.c
parent3942d29918522ba6a393c19388301ec04df429cd (diff)
mm/mempool: allow NULL `pool' pointer in mempool_destroy()
mempool_destroy() does not tolerate a NULL mempool_t pointer argument and performs a NULL-pointer dereference. This requires additional attention and effort from developers/reviewers and forces all mempool_destroy() callers to do a NULL check if (pool) mempool_destroy(pool); Or, otherwise, be invalid mempool_destroy() users. Tweak mempool_destroy() and NULL-check the pointer there. Proposed by Andrew Morton. Link: Signed-off-by: Sergey Senozhatsky <> Acked-by: David Rientjes <> Cc: Julia Lawall <> Cc: Joe Perches <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'mm/mempool.c')
1 files changed, 3 insertions, 0 deletions
diff --git a/mm/mempool.c b/mm/mempool.c
index 2cc08de8b1db..4c533bc51d73 100644
--- a/mm/mempool.c
+++ b/mm/mempool.c
@@ -150,6 +150,9 @@ static void *remove_element(mempool_t *pool)
void mempool_destroy(mempool_t *pool)
+ if (unlikely(!pool))
+ return;
while (pool->curr_nr) {
void *element = remove_element(pool);
pool->free(element, pool->pool_data);