path: root/mm/shmem.c
diff options
authorPaul Burton <>2014-09-24 10:45:37 +0100
committerRalf Baechle <>2014-09-26 11:33:11 +0200
commitc8c0da6bdf0f0d6f59fc23aab6ee373a131df82d (patch)
treef90e0aaa79c1337055460cb7c7bd8a4575ffcae9 /mm/shmem.c
parent0f33be009b89d2268e94194dc4fd01a7851b6d51 (diff)
MIPS: Fix MFC1 & MFHC1 emulation for 64-bit MIPS systems
Commit bbd426f542cb "MIPS: Simplify FP context access" modified the SIFROMREG & SIFROMHREG macros such that they return unsigned rather than signed 32b integers. I had believed that to be fine, but inadvertently missed the MFC1 & MFHC1 cases which write to a struct pt_regs regs element. On MIPS32 this is fine, but on 64 bit those saved regs' fields are 64 bit wide. Using unsigned values caused the 32 bit value from the FP register to be zero rather than sign extended as the architecture specifies, causing incorrect emulation of the MFC1 & MFHc1 instructions. Fix by reintroducing the casts to signed integers, and therefore the sign extension. Signed-off-by: Paul Burton <> Cc: # v3.15+ Cc: Patchwork: Signed-off-by: Ralf Baechle <>
Diffstat (limited to 'mm/shmem.c')
0 files changed, 0 insertions, 0 deletions