summaryrefslogtreecommitdiff
path: root/net/core
diff options
context:
space:
mode:
authorTimo Teräs <timo.teras@iki.fi>2015-11-16 14:36:32 +0200
committerDavid S. Miller <davem@davemloft.net>2015-11-17 14:37:16 -0500
commit6c606fa32c4272894248c1abbc15257fc04250be (patch)
treed9e2e25169454d4c8c64b5ce9eae52f3407b099f /net/core
parentf1a454a37618b819f2528ccd234f77a02b3a6016 (diff)
downloadlinux-6c606fa32c4272894248c1abbc15257fc04250be.tar.gz
via-velocity: unconditionally drop frames with bad l2 length
By default the driver allowed incorrect frames to be received. What is worse the code does not handle very short frames correctly. The FCS length is unconditionally subtracted, and the underflow can cause skb_put to be called with large number after implicit cast to unsigned. And indeed, an skb_over_panic() was observed with via-velocity. This removes the module parameter as it does not work in it's current state, and should be implemented via NETIF_F_RXALL if needed. Suggested-by: Francois Romieu <romieu@fr.zoreil.com> Signed-off-by: Timo Teräs <timo.teras@iki.fi> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
0 files changed, 0 insertions, 0 deletions