path: root/sound/soc/codecs/rt5677.c
diff options
authorLinus Walleij <>2015-11-04 09:56:26 +0100
committerLinus Walleij <>2015-11-19 09:24:35 +0100
commit58383c78425e4ee1c077253cf297b641c861c02e (patch)
tree606949d2c6db8176c0659eaa935d022bf6d19974 /sound/soc/codecs/rt5677.c
parent8005c49d9aea74d382f474ce11afbbc7d7130bec (diff)
gpio: change member .dev to .parent
The name .dev in a struct is normally reserved for a struct device that is let us say a superclass to the thing described by the struct. struct gpio_chip stands out by confusingly using a struct device *dev to point to the parent device (such as a platform_device) that represents the hardware. As we want to give gpio_chip:s real devices, this is not working. We need to rename this member to parent. This was done by two coccinelle scripts, I guess it is possible to combine them into one, but I don't know such stuff. They look like this: @@ struct gpio_chip *var; @@ -var->dev +var->parent and: @@ struct gpio_chip var; @@ +var.parent and: @@ struct bgpio_chip *var; @@ -var-> +var->gc.parent Plus a few instances of bgpio that I couldn't figure out how to teach Coccinelle to rewrite. This patch hits all over the place, but I *strongly* prefer this solution to any piecemal approaches that just exercise patch mechanics all over the place. It mainly hits drivers/gpio and drivers/pinctrl which is my own backyard anyway. Cc: Haavard Skinnemoen <> Cc: Rafał Miłecki <> Cc: Richard Purdie <> Cc: Mauro Carvalho Chehab <> Cc: Alek Du <> Cc: Jaroslav Kysela <> Cc: Takashi Iwai <> Acked-by: Dmitry Torokhov <> Acked-by: Greg Kroah-Hartman <> Acked-by: Lee Jones <> Acked-by: Jiri Kosina <> Acked-by: Hans-Christian Egtvedt <> Acked-by: Jacek Anaszewski <> Signed-off-by: Linus Walleij <>
Diffstat (limited to 'sound/soc/codecs/rt5677.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index b4cd7e3bf5f8..1f590b5a6718 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -4674,7 +4674,7 @@ static void rt5677_init_gpio(struct i2c_client *i2c)
rt5677->gpio_chip = rt5677_template_chip;
rt5677->gpio_chip.ngpio = RT5677_GPIO_NUM;
- rt5677-> = &i2c->dev;
+ rt5677->gpio_chip.parent = &i2c->dev;
rt5677->gpio_chip.base = -1;
ret = gpiochip_add(&rt5677->gpio_chip);