path: root/tools/perf/builtin-sched.c
diff options
authorJiri Olsa <>2015-11-02 12:10:25 +0100
committerArnaldo Carvalho de Melo <>2015-11-05 12:51:00 -0300
commit0014de172d228e450377d1fd079d94e67128d27f (patch)
tree0a39934f9f5d9c383f7debd020e89c1efe6cb2b4 /tools/perf/builtin-sched.c
parent98d3b258ede2cdac31a2728543f652964e597e79 (diff)
perf sched latency: Fix thread pid reuse issue
The latency subcommand holds a tree of working atoms sorted by thread's pid/tid. If there's new thread with same pid and tid, the old working atom is found and assert bug condition is hit in search function: thread_atoms_search: Assertion `!(thread != atoms->thread)' failed Changing the sort function to use thread object pointers together with pid and tid check. This way new thread will never find old one with same pid/tid. Link: Reported-by: Mohit Agrawal <> Signed-off-by: Jiri Olsa <> Acked-by: Namhyung Kim <> Cc: David Ahern <> Cc: Peter Zijlstra <> Link: Signed-off-by: Arnaldo Carvalho de Melo <>
Diffstat (limited to 'tools/perf/builtin-sched.c')
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 0ee6d900e100..e3d3e32c0a93 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1203,12 +1203,13 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_
static int pid_cmp(struct work_atoms *l, struct work_atoms *r)
+ if (l->thread == r->thread)
+ return 0;
if (l->thread->tid < r->thread->tid)
return -1;
if (l->thread->tid > r->thread->tid)
return 1;
- return 0;
+ return (int)(l->thread - r->thread);
static int avg_cmp(struct work_atoms *l, struct work_atoms *r)