path: root/tools/perf/tests
diff options
authorWang Nan <>2016-01-11 13:48:02 +0000
committerArnaldo Carvalho de Melo <>2016-01-11 19:22:22 -0300
commit71b3ee7e65ffb48135d875d9c36e3183b9ecffeb (patch)
tree44e032ad00d350d23dac06e6be4d47d100ff4f4e /tools/perf/tests
parent0c4d40d580752dd7d639208782f71e317b16be67 (diff)
perf test: Fix false TEST_OK result for 'perf test hist'
Commit 71d6de64fedd ("perf test: Fix hist testcases when kptr_restrict is on") solves a double free problem when 'perf test hist' calling setup_fake_machine(). However, the result is still incorrect. For example: $ ./perf test -v 'filtering hist entries' 25: Test filtering hist entries : --- start --- test child forked, pid 4186 Cannot create kernel maps test child finished with 0 ---- end ---- Test filtering hist entries: Ok In this case the body of this test is not get executed at all, but the result is 'Ok'. Actually, in setup_fake_machine() there's no need to create real kernel maps. What we want are the fake maps. This patch removes the machine__create_kernel_maps() in setup_fake_machine(), so it won't be affected by kptr_restrict setting. Test result: $ cat /proc/sys/kernel/kptr_restrict 1 $ ~/perf test -v hist 15: Test matching and linking multiple hists : --- start --- test child forked, pid 24031 test child finished with 0 ---- end ---- Test matching and linking multiple hists: Ok [SNIP] Suggested-and-Acked-by: Namhyung Kim <> Signed-off-by: Wang Nan <> Tested-by: Arnaldo Carvalho de Melo <> Cc: Jiri Olsa <> Cc: Masami Hiramatsu <> Cc: Zefan Li <> Cc: Link: Signed-off-by: Arnaldo Carvalho de Melo <>
Diffstat (limited to 'tools/perf/tests')
1 files changed, 0 insertions, 5 deletions
diff --git a/tools/perf/tests/hists_common.c b/tools/perf/tests/hists_common.c
index bcfd081ee1d2..071a8b5f5232 100644
--- a/tools/perf/tests/hists_common.c
+++ b/tools/perf/tests/hists_common.c
@@ -87,11 +87,6 @@ struct machine *setup_fake_machine(struct machines *machines)
return NULL;
- if (machine__create_kernel_maps(machine)) {
- pr_debug("Cannot create kernel maps\n");
- return NULL;
- }
for (i = 0; i < ARRAY_SIZE(fake_threads); i++) {
struct thread *thread;