path: root/virt
diff options
authorChristoffer Dall <>2015-11-24 16:34:31 +0100
committerChristoffer Dall <>2015-11-24 18:08:37 +0100
commit9f958c11b780af74fc311b96d6124740aa21cc68 (patch)
tree1bd4c43e53f02a7513bb94d2992e1cf64c4863af /virt
parent0e3dfda91d9fe8e2c4d0b5d21434b173a241eeaf (diff)
KVM: arm/arm64: vgic: Trust the LR state for HW IRQs
We were probing the physial distributor state for the active state of a HW virtual IRQ, because we had seen evidence that the LR state was not cleared when the guest deactivated a virtual interrupted. However, this issue turned out to be a software bug in the GIC, which was solved by: 84aab5e68c2a5e1e18d81ae8308c3ce25d501b29 (KVM: arm/arm64: arch_timer: Preserve physical dist. active state on, 2015-11-24) Therefore, get rid of the complexities and just look at the LR. Reviewed-by: Marc Zyngier <> Signed-off-by: Christoffer Dall <>
Diffstat (limited to 'virt')
1 files changed, 2 insertions, 14 deletions
diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
index 97e2c088e1e9..65461f821a75 100644
--- a/virt/kvm/arm/vgic.c
+++ b/virt/kvm/arm/vgic.c
@@ -1417,25 +1417,13 @@ static bool vgic_process_maintenance(struct kvm_vcpu *vcpu)
static bool vgic_sync_hwirq(struct kvm_vcpu *vcpu, int lr, struct vgic_lr vlr)
struct vgic_dist *dist = &vcpu->kvm->arch.vgic;
- struct irq_phys_map *map;
- bool phys_active;
bool level_pending;
- int ret;
if (!(vlr.state & LR_HW))
return false;
- map = vgic_irq_map_search(vcpu, vlr.irq);
- BUG_ON(!map);
- ret = irq_get_irqchip_state(map->irq,
- &phys_active);
- WARN_ON(ret);
- if (phys_active)
- return 0;
+ if (vlr.state & LR_STATE_ACTIVE)
+ return false;
level_pending = process_queued_irq(vcpu, lr, vlr);