diff options
| author | Jeff Cody <jcody@redhat.com> | 2016-03-22 23:33:38 -0400 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2016-04-15 17:22:11 +0200 |
| commit | 0211b9becc0d763e4866e229488cbc700ba64a1f (patch) | |
| tree | 4ffe9c1d8caa1f7a116d83f274667c713a2829bf | |
| parent | 7fa84cd8d4b5ce3939bc2498010f6640e855dbad (diff) | |
| download | qemu-0211b9becc0d763e4866e229488cbc700ba64a1f.tar.gz | |
block/vpc: set errp in vpc_create
Add more useful error information to failure paths in vpc_create().
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | block/vpc.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/block/vpc.c b/block/vpc.c index 3713ec3a5f..5aded1a18b 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -874,6 +874,7 @@ static int vpc_create(const char *filename, QemuOpts *opts, Error **errp) } else if (!strcmp(disk_type_param, "fixed")) { disk_type = VHD_FIXED; } else { + error_setg(errp, "Invalid disk type, %s", disk_type_param); ret = -EINVAL; goto out; } @@ -924,6 +925,7 @@ static int vpc_create(const char *filename, QemuOpts *opts, Error **errp) total_sectors = total_size / BDRV_SECTOR_SIZE; /* Allow a maximum disk size of approximately 2 TB */ if (total_sectors > VHD_MAX_SECTORS) { + error_setg(errp, "Disk size is too large, max size is 2040 GiB"); ret = -EFBIG; goto out; } @@ -974,6 +976,9 @@ static int vpc_create(const char *filename, QemuOpts *opts, Error **errp) } else { ret = create_fixed_disk(blk, buf, total_size); } + if (ret < 0) { + error_setg(errp, "Unable to create or write VHD header"); + } out: blk_unref(blk); |