summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormalc <malc@c046a42c-6fe2-441c-8c8c-71466251a162>2008-06-08 01:42:47 +0000
committermalc <malc@c046a42c-6fe2-441c-8c8c-71466251a162>2008-06-08 01:42:47 +0000
commit731ba0cec2ae7071da75902a8071ac718c86cb14 (patch)
tree017390d5d858f6b73c711ca6d86c7d5fe1cb3a9a
parente2eef1703b536d42b89f8046faf7adeaa0e42ba1 (diff)
downloadqemu-731ba0cec2ae7071da75902a8071ac718c86cb14.tar.gz
Fix some signedness issues caught by gcc 4.3
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4696 c046a42c-6fe2-441c-8c8c-71466251a162
-rw-r--r--hw/gus.c4
-rw-r--r--hw/gusemu.h4
-rw-r--r--hw/gusemu_mixer.c6
3 files changed, 8 insertions, 6 deletions
diff --git a/hw/gus.c b/hw/gus.c
index 57753a7f5c..c7a88463f0 100644
--- a/hw/gus.c
+++ b/hw/gus.c
@@ -58,7 +58,7 @@ typedef struct GUSState {
QEMUSoundCard card;
int freq;
int pos, left, shift, irqs;
- uint16_t *mixbuf;
+ GUSsample *mixbuf;
uint8_t himem[1024 * 1024 + 32 + 4096];
int samples;
SWVoiceOut *voice;
@@ -198,7 +198,7 @@ void GUS_dmarequest (GUSEmuState *der)
int GUS_read_DMA (void *opaque, int nchan, int dma_pos, int dma_len)
{
GUSState *s = opaque;
- int8_t tmpbuf[4096];
+ char tmpbuf[4096];
int pos = dma_pos, mode, left = dma_len - dma_pos;
ldebug ("read DMA %#x %d\n", dma_pos, dma_len);
diff --git a/hw/gusemu.h b/hw/gusemu.h
index 2e9c1c0c77..a64300a09f 100644
--- a/hw/gusemu.h
+++ b/hw/gusemu.h
@@ -32,12 +32,14 @@
typedef unsigned short GUSword;
typedef unsigned int GUSdword;
typedef signed char GUSchar;
+ typedef signed short GUSsample;
#else
#include <stdint.h>
typedef int8_t GUSchar;
typedef uint8_t GUSbyte;
typedef uint16_t GUSword;
typedef uint32_t GUSdword;
+ typedef int16_t GUSsample;
#endif
typedef struct _GUSEmuState
@@ -91,7 +93,7 @@ void gus_dma_transferdata(GUSEmuState *state, char *dma_addr, unsigned int count
/* If the interrupts are asynchronous, it may be needed to use a separate thread mixing into a temporary */
/* audio buffer in order to avoid quality loss caused by large numsamples and elapsed_time values. */
-void gus_mixvoices(GUSEmuState *state, unsigned int playback_freq, unsigned int numsamples, short *bufferpos);
+void gus_mixvoices(GUSEmuState *state, unsigned int playback_freq, unsigned int numsamples, GUSsample *bufferpos);
/* recommended range: 10 < numsamples < 100 */
/* lower values may result in increased rounding error, higher values often cause audible timing delays */
diff --git a/hw/gusemu_mixer.c b/hw/gusemu_mixer.c
index b3b5aa5d79..6d8d9ced11 100644
--- a/hw/gusemu_mixer.c
+++ b/hw/gusemu_mixer.c
@@ -33,7 +33,7 @@
/* samples are always 16bit stereo (4 bytes each, first right then left interleaved) */
void gus_mixvoices(GUSEmuState * state, unsigned int playback_freq, unsigned int numsamples,
- short *bufferpos)
+ GUSsample *bufferpos)
{
/* note that byte registers are stored in the upper half of each voice register! */
GUSbyte *gusptr;
@@ -170,8 +170,8 @@ void gus_mixvoices(GUSEmuState * state, unsigned int playback_freq, unsigned int
}
/* mix samples into buffer */
- *(bufferpos + 2 * sample) += (short) ((sample1 * PanningPos) >> 4); /* right */
- *(bufferpos + 2 * sample + 1) += (short) ((sample1 * (15 - PanningPos)) >> 4); /* left */
+ *(bufferpos + 2 * sample) += (GUSsample) ((sample1 * PanningPos) >> 4); /* right */
+ *(bufferpos + 2 * sample + 1) += (GUSsample) ((sample1 * (15 - PanningPos)) >> 4); /* left */
}
/* write back voice and volume */
GUSvoice(wVSRCurrVol) = Volume32 / 32;