summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2014-02-07 15:35:56 +0100
committerKevin Wolf <kwolf@redhat.com>2014-02-09 09:12:39 +0100
commitaf91f9a73c3a67eebbf4120cae62b82db8eaae19 (patch)
tree11b8cfd818acf0d5fae29596bc57e5eabba2a6ca
parent99c4a85ce65863e6ba6668164d47c0d7c645e3aa (diff)
downloadqemu-af91f9a73c3a67eebbf4120cae62b82db8eaae19.tar.gz
block: bdrv_aligned_pwritev: Assert overlap range
This adds assertions that the request that we actually end up passing to the block driver (which includes RMW data and has therefore potentially been rounded to alignment boundaries) is fully covered by the overlap_{offset,size} fields of the associated BdrvTrackedRequest. Suggested-by: Laszlo Ersek <lersek@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
-rw-r--r--block.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/block.c b/block.c
index c1d1f74b88..a027823ea4 100644
--- a/block.c
+++ b/block.c
@@ -3134,6 +3134,8 @@ static int coroutine_fn bdrv_aligned_pwritev(BlockDriverState *bs,
waited = wait_serialising_requests(req);
assert(!waited || !req->serialising);
+ assert(req->overlap_offset <= offset);
+ assert(offset + bytes <= req->overlap_offset + req->overlap_bytes);
ret = notifier_with_return_list_notify(&bs->before_write_notifiers, req);