diff options
author | Stefan Weil <weil@mail.berlios.de> | 2009-05-24 22:33:34 +0200 |
---|---|---|
committer | Anthony Liguori <aliguori@us.ibm.com> | 2009-05-27 09:47:25 -0500 |
commit | 738208b656004e3e7a727b546107556213fbca82 (patch) | |
tree | e2c81e72d5ad6b7d4578095bc096d95a36dc4185 | |
parent | 61348b076bf9b8cb31bdd26d2eeb41882ee27282 (diff) | |
download | qemu-738208b656004e3e7a727b546107556213fbca82.tar.gz |
VNC: Fix memory allocation (wrong structure size).
Pointer vs addresses a VncDisplay structure,
so it is sufficient to allocate sizeof(VncDisplay)
or sizeof(*vs) bytes instead of the much larger
sizeof(VncState).
Maybe the misleading name should be fixed, too:
the code contains many places where vs is used,
sometimes it is a VncState *, sometimes it is a
VncDisplay *. vd would be a better name.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
-rw-r--r-- | vnc.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -2306,9 +2306,8 @@ static void vnc_listen_read(void *opaque) void vnc_display_init(DisplayState *ds) { - VncDisplay *vs; + VncDisplay *vs = qemu_mallocz(sizeof(*vs)); - vs = qemu_mallocz(sizeof(VncState)); dcl = qemu_mallocz(sizeof(DisplayChangeListener)); ds->opaque = vs; |