diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2011-11-09 19:34:28 +0000 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2011-11-11 12:49:53 -0600 |
| commit | 35914dc7240f7d81e22219217cfa826c2c383e7b (patch) | |
| tree | 4b1f3dbd6cab28dae16730890f4c87631c671d13 | |
| parent | 7dd47667b9b0b23807fc1a550644fc2427462f41 (diff) | |
| download | qemu-35914dc7240f7d81e22219217cfa826c2c383e7b.tar.gz | |
hw/tc58128.c: Remove unnecessary check for g_malloc failure
Remove a check for g_malloc failing: this never happens.
Also use g_malloc rather than g_malloc0 as we immediately
memset the entire region and so zero-initialising it is pointless.
Spotted by Coverity (see bug 887883).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| -rw-r--r-- | hw/tc58128.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/hw/tc58128.c b/hw/tc58128.c index ee3ecad51a..4ce80b18f3 100644 --- a/hw/tc58128.c +++ b/hw/tc58128.c @@ -30,12 +30,8 @@ static void init_dev(tc58128_dev * dev, const char *filename) int ret, blocks; dev->state = WAIT; - dev->flash_contents = g_malloc0(FLASH_SIZE); + dev->flash_contents = g_malloc(FLASH_SIZE); memset(dev->flash_contents, 0xff, FLASH_SIZE); - if (!dev->flash_contents) { - fprintf(stderr, "could not alloc memory for flash\n"); - exit(1); - } if (filename) { /* Load flash image skipping the first block */ ret = load_image(filename, dev->flash_contents + 528 * 32); |