summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2014-02-21 13:36:49 +0100
committerMichael Roth <mdroth@linux.vnet.ibm.com>2014-02-25 13:34:15 -0600
commit4736fb34f7d6ca2962c0a943ca4835fd25ca6140 (patch)
treef32cec6db984831bf9c5ab15637c1a33f74c3721
parent6d0a48acd8442e1a74443c190b58c60547788fdc (diff)
downloadqemu-4736fb34f7d6ca2962c0a943ca4835fd25ca6140.tar.gz
qga: Fix memory allocation pasto
qmp_guest_file_seek() allocates memory for a GuestFileRead object instead of the GuestFileSeek object it actually uses. Harmless, because the GuestFileRead is slightly larger. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> (cherry picked from commit 10b7c5dd0da1a92182e87f5fc1887d779ad1a9e8) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
-rw-r--r--qga/commands-posix.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 8100bee67e..8763308cac 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -525,7 +525,7 @@ struct GuestFileSeek *qmp_guest_file_seek(int64_t handle, int64_t offset,
if (ret == -1) {
error_setg_errno(err, errno, "failed to seek file");
} else {
- seek_data = g_malloc0(sizeof(GuestFileRead));
+ seek_data = g_new0(GuestFileSeek, 1);
seek_data->position = ftell(fh);
seek_data->eof = feof(fh);
}