diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2014-08-13 13:50:24 +0200 |
|---|---|---|
| committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2014-09-08 11:23:05 -0500 |
| commit | cd4acff8d0eaa721a83b8b1253abb826bba53632 (patch) | |
| tree | 279d479505457298853074cba168b8adef82f061 | |
| parent | 4b59161253e26b74e86c63dc7992b7aec9bdeeb0 (diff) | |
| download | qemu-cd4acff8d0eaa721a83b8b1253abb826bba53632.tar.gz | |
hostmem: set MPOL_MF_MOVE
When memory is allocated on a wrong node, MPOL_MF_STRICT
doesn't move it - it just fails the allocation.
A simple way to reproduce the failure is with mlock=on
realtime feature.
The code comment actually says: "ensure policy won't be ignored"
so setting MPOL_MF_MOVE seems like a better way to do this.
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 288d3322022d6ad646407f3ca6f1a6a746565b9a)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
| -rw-r--r-- | backends/hostmem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/backends/hostmem.c b/backends/hostmem.c index ca10c51b51..a9905c04a6 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -304,7 +304,7 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) /* ensure policy won't be ignored in case memory is preallocated * before mbind(). note: MPOL_MF_STRICT is ignored on hugepages so * this doesn't catch hugepage case. */ - unsigned flags = MPOL_MF_STRICT; + unsigned flags = MPOL_MF_STRICT | MPOL_MF_MOVE; /* check for invalid host-nodes and policies and give more verbose * error messages than mbind(). */ |