diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-03-13 18:51:38 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2015-03-16 17:07:25 +0100 |
| commit | 6ec46ad541b20a1530cedc741d19eea9ffc39ac3 (patch) | |
| tree | 012ab1df86f36c93cbfe493d07432e55573f8700 | |
| parent | a1f688f4152e65260b94f37543521ceff8bfebe4 (diff) | |
| download | qemu-6ec46ad541b20a1530cedc741d19eea9ffc39ac3.tar.gz | |
block: Fix block-set-write-threshold not to use funky error class
Error classes are a leftover from the days of "rich" error objects.
New code should always use ERROR_CLASS_GENERIC_ERROR. Commit e246211
added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | block/write-threshold.c | 2 | ||||
| -rw-r--r-- | qapi/block-core.json | 4 |
2 files changed, 1 insertions, 5 deletions
diff --git a/block/write-threshold.c b/block/write-threshold.c index c2cd517716..a53c1f5e65 100644 --- a/block/write-threshold.c +++ b/block/write-threshold.c @@ -112,7 +112,7 @@ void qmp_block_set_write_threshold(const char *node_name, bs = bdrv_find_node(node_name); if (!bs) { - error_set(errp, QERR_DEVICE_NOT_FOUND, node_name); + error_setg(errp, "Device '%s' not found", node_name); return; } diff --git a/qapi/block-core.json b/qapi/block-core.json index 90586a5949..42c885047f 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1961,10 +1961,6 @@ # @write-threshold: configured threshold for the block device, bytes. # Use 0 to disable the threshold. # -# Returns: Nothing on success -# If @node name is not found on the block device graph, -# DeviceNotFound -# # Since: 2.3 ## { 'command': 'block-set-write-threshold', |