summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDr. David Alan Gilbert <dgilbert@redhat.com>2015-11-18 11:48:41 +0000
committerJuan Quintela <quintela@redhat.com>2015-11-19 11:49:53 +0100
commit5df5416e639cd75bd85d243af41387c2418fa580 (patch)
treebb45896d8dc18840572f5f3456d3a4dedc6be594
parent95a7788b2faa81ff95675f1e46a3272a612b35de (diff)
downloadqemu-5df5416e639cd75bd85d243af41387c2418fa580.tar.gz
Unneeded NULL check
The check is unneccesary, we read the value at the start of the thread, use it, and never change it. The value is checked to be non-NULL before thread creation. Spotted by coverity, CID 1339211 Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
-rw-r--r--migration/migration.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/migration/migration.c b/migration/migration.c
index 265d13a74f..1a42aee412 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1345,7 +1345,7 @@ static void *source_return_path_thread(void *opaque)
break;
}
}
- if (rp && qemu_file_get_error(rp)) {
+ if (qemu_file_get_error(rp)) {
trace_source_return_path_thread_bad_end();
mark_source_rp_bad(ms);
}