summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlberto Garcia <berto@igalia.com>2016-07-28 11:08:13 +0300
committerStefan Hajnoczi <stefanha@redhat.com>2016-08-05 09:59:06 +0100
commit5fc8c052ce0ab8cc476a4a3888cc31d52783c315 (patch)
treec45b5eab6e99337ce28042f8c1120bdc11e1e98a
parentaaa1e77ffae5255fb2a35284e7fc721742bb41c8 (diff)
downloadqemu-5fc8c052ce0ab8cc476a4a3888cc31d52783c315.tar.gz
throttle: Test burst limits lower than the normal limits
This checks that making FOO_max lower than FOO is not allowed. We could also forbid having FOO_max == FOO, but that doesn't have any odd side effects and it would require us to update several other tests, so let's keep it simple. Signed-off-by: Alberto Garcia <berto@igalia.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-id: 2f90f9ee58aa14b7bd985f67c5996b06e0ab6c19.1469693110.git.berto@igalia.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
-rw-r--r--tests/test-throttle.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/test-throttle.c b/tests/test-throttle.c
index afe094bcc4..363b59a38f 100644
--- a/tests/test-throttle.c
+++ b/tests/test-throttle.c
@@ -394,6 +394,14 @@ static void test_max_is_missing_limit(void)
cfg.buckets[i].max = 0;
cfg.buckets[i].avg = 100;
g_assert(throttle_is_valid(&cfg, NULL));
+
+ cfg.buckets[i].max = 30;
+ cfg.buckets[i].avg = 100;
+ g_assert(!throttle_is_valid(&cfg, NULL));
+
+ cfg.buckets[i].max = 100;
+ cfg.buckets[i].avg = 100;
+ g_assert(throttle_is_valid(&cfg, NULL));
}
}