diff options
| author | Fam Zheng <famz@redhat.com> | 2017-04-07 14:54:09 +0800 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2017-04-07 14:44:06 +0200 |
| commit | c26a5ab71338a53340257233bd172bbe22c06b16 (patch) | |
| tree | 5d3bb905458d51f80b66b0376b483152113f22bb | |
| parent | 1bf03e66fd03af46ff0f98dd04b6e28f432ac1e3 (diff) | |
| download | qemu-c26a5ab71338a53340257233bd172bbe22c06b16.tar.gz | |
block: Fix unpaired aio_disable_external in external snapshot
bdrv_replace_child_noperm tries to hand over the quiesce_counter state
from old bs to the new one, but if they are not on the same aio context
this causes unbalance.
Fix this by setting the correct aio context before calling
bdrv_append().
Reported-by: Ed Swierk <eswierk@skyportsystems.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | blockdev.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/blockdev.c b/blockdev.c index 040c152512..4927914ce3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1772,6 +1772,8 @@ static void external_snapshot_prepare(BlkActionState *common, return; } + bdrv_set_aio_context(state->new_bs, state->aio_context); + /* This removes our old bs and adds the new bs. This is an operation that * can fail, so we need to do it in .prepare; undoing it for abort is * always possible. */ @@ -1789,8 +1791,6 @@ static void external_snapshot_commit(BlkActionState *common) ExternalSnapshotState *state = DO_UPCAST(ExternalSnapshotState, common, common); - bdrv_set_aio_context(state->new_bs, state->aio_context); - /* We don't need (or want) to use the transactional * bdrv_reopen_multiple() across all the entries at once, because we * don't want to abort all of them if one of them fails the reopen */ |