diff options
| author | Max Reitz <mreitz@redhat.com> | 2017-06-13 19:20:05 +0200 |
|---|---|---|
| committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2017-08-24 16:57:00 -0500 |
| commit | 1828d47845ca92ec3fcfd82399f036526afc6a31 (patch) | |
| tree | 7fdd89c0ae912991a4e3409a06af9182085827dc | |
| parent | 1dd3ba38f6ebf5c11194b420c0539c05cfed1f51 (diff) | |
| download | qemu-1828d47845ca92ec3fcfd82399f036526afc6a31.tar.gz | |
blkdebug: Catch bs->exact_filename overflow
The bs->exact_filename field may not be sufficient to store the full
blkdebug node filename. In this case, we should not generate a filename
at all instead of an unusable one.
Cc: qemu-stable@nongnu.org
Reported-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170613172006.19685-2-mreitz@redhat.com
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
(cherry picked from commit de81d72d3d13a19edf4d461be3b0f5a877be0234)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
| -rw-r--r-- | block/blkdebug.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/block/blkdebug.c b/block/blkdebug.c index 5ccb9cecb3..63bc5d4f03 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -840,9 +840,13 @@ static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) } if (!force_json && bs->file->bs->exact_filename[0]) { - snprintf(bs->exact_filename, sizeof(bs->exact_filename), - "blkdebug:%s:%s", s->config_file ?: "", - bs->file->bs->exact_filename); + int ret = snprintf(bs->exact_filename, sizeof(bs->exact_filename), + "blkdebug:%s:%s", s->config_file ?: "", + bs->file->bs->exact_filename); + if (ret >= sizeof(bs->exact_filename)) { + /* An overflow makes the filename unusable, so do not report any */ + bs->exact_filename[0] = 0; + } } opts = qdict_new(); |