diff options
| author | Fam Zheng <famz@redhat.com> | 2014-08-28 13:56:10 +0800 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2014-08-29 17:10:18 +0100 |
| commit | 810f4f86b7ebfd0a89fb65bff24aae006483cd58 (patch) | |
| tree | 017794af9465c02c630043e88cace4b8bfcab51a /block/nfs.c | |
| parent | a2f468e48f8b6559ec9123e94948bc373b788941 (diff) | |
| download | qemu-810f4f86b7ebfd0a89fb65bff24aae006483cd58.tar.gz | |
nfs: Fix leak of opts in nfs_file_open
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Benoît Canet <benoit.canet@nodalink.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'block/nfs.c')
| -rw-r--r-- | block/nfs.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/block/nfs.c b/block/nfs.c index 93d87f3256..194f301501 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -393,16 +393,20 @@ static int nfs_file_open(BlockDriverState *bs, QDict *options, int flags, qemu_opts_absorb_qdict(opts, options, &local_err); if (local_err) { error_propagate(errp, local_err); - return -EINVAL; + ret = -EINVAL; + goto out; } ret = nfs_client_open(client, qemu_opt_get(opts, "filename"), (flags & BDRV_O_RDWR) ? O_RDWR : O_RDONLY, errp); if (ret < 0) { - return ret; + goto out; } bs->total_sectors = ret; - return 0; + ret = 0; +out: + qemu_opts_del(opts); + return ret; } static int nfs_file_create(const char *url, QemuOpts *opts, Error **errp) |