diff options
| author | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | 2010-10-18 16:53:53 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2010-10-22 14:49:35 +0200 |
| commit | 72893756e0da74fcb626c52dfff1fc6e9de84f0c (patch) | |
| tree | ca761120b722477d05c62f2a1d9cd25bd5352ee3 /block/qcow2-snapshot.c | |
| parent | d03703c81a202cea156811e5dbc8e88627c19986 (diff) | |
| download | qemu-72893756e0da74fcb626c52dfff1fc6e9de84f0c.tar.gz | |
qcow2: Support exact L1 table growth
The L1 table grow operation includes a size calculation that bumps up
the new L1 table size in order to anticipate the size needs of vmstate
data. This helps reduce the number of times that the L1 table has to be
grown when vmstate data is appended.
This size overhead is not necessary during image creation,
bdrv_truncate(), or snapshot goto operations. In fact, existing
qemu-iotests that exercise table growth are no longer able to trigger it
because image creation preallocates an L1 table that is too large after
changes to qcow_create2().
This patch keeps the size calculation but also adds exact growth for
callers that do not want to inflate the L1 table size unnecessarily.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/qcow2-snapshot.c')
| -rw-r--r-- | block/qcow2-snapshot.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index bbfcaaae22..8dd5df0bcd 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -327,7 +327,7 @@ int qcow2_snapshot_goto(BlockDriverState *bs, const char *snapshot_id) if (qcow2_update_snapshot_refcount(bs, s->l1_table_offset, s->l1_size, -1) < 0) goto fail; - if (qcow2_grow_l1_table(bs, sn->l1_size) < 0) + if (qcow2_grow_l1_table(bs, sn->l1_size, true) < 0) goto fail; s->l1_size = sn->l1_size; |