summaryrefslogtreecommitdiff
path: root/blockdev.c
diff options
context:
space:
mode:
authorJeff Cody <jcody@redhat.com>2014-02-13 09:23:38 -0500
committerStefan Hajnoczi <stefanha@redhat.com>2014-02-14 18:05:39 +0100
commitcc67f4d1f9645e8e6d90aee84ca19162d661f082 (patch)
treefe989e6b91f313eba88caeca2df8adb1f35dfdff /blockdev.c
parent2aa4a86f59c7093e03d2ec18c5d5f08c957d1a78 (diff)
downloadqemu-cc67f4d1f9645e8e6d90aee84ca19162d661f082.tar.gz
block: mirror - use local_err to avoid NULL errp
When starting a block job, commit_active_start() relies on whether *errp is set by mirror_start_job. This allows it to determine if the mirror job start failed, so that it can clean up any changes to open flags from the bdrv_reopen(). If errp is NULL, then it will not be able to determine if mirror_start_job failed or not. To avoid this, use a local Error variable, and then propagate the error (if any) to errp. Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Jeff Cody <jcody@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'blockdev.c')
0 files changed, 0 insertions, 0 deletions