diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2018-02-07 17:29:20 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2018-02-13 12:27:17 +0100 |
| commit | cb2af9176fcb6b0b71bbac8c83498c4caa37ab05 (patch) | |
| tree | d0200c3d14e51beb9df7d675fbbe102a5eab7af6 /blockdev.c | |
| parent | de7269d293bc3a7fba98a0f12781eccb4ea4be1e (diff) | |
| download | qemu-cb2af9176fcb6b0b71bbac8c83498c4caa37ab05.tar.gz | |
block: early check for blockers on drive-mirror
Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE,
it is checked a bit late and the result is that the target is
created even if drive-mirror subsequently fails. Add an early
check to avoid this.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/blockdev.c b/blockdev.c index bdbdeae7e4..7423c5317b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3569,6 +3569,11 @@ void qmp_drive_mirror(DriveMirror *arg, Error **errp) return; } + /* Early check to avoid creating target */ + if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) { + return; + } + aio_context = bdrv_get_aio_context(bs); aio_context_acquire(aio_context); |