summaryrefslogtreecommitdiff
path: root/blockdev.c
diff options
context:
space:
mode:
authorWen Congyang <wency@cn.fujitsu.com>2015-05-15 15:51:36 +0800
committerJeff Cody <jcody@redhat.com>2015-07-14 21:50:13 -0400
commit48ac0a4df84662f23da25262443e1810b70c2228 (patch)
tree16ae278a96c3b019ab94d0b7b0889043a718d649 /blockdev.c
parent17d9716d7b5381c4b6566bb1a06267d2bfcd1821 (diff)
downloadqemu-48ac0a4df84662f23da25262443e1810b70c2228.tar.gz
mirror: correct buf_size
If bus_size is less than 0, the command fails. If buf_size is 0, use DEFAULT_MIRROR_BUF_SIZE. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> Reviewed-by: Fam Zheng <famz@redhat.com> Message-id: 5555A588.3080907@cn.fujitsu.com Signed-off-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'blockdev.c')
-rw-r--r--blockdev.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/blockdev.c b/blockdev.c
index 50421c8b98..62a4586cd6 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2639,8 +2639,6 @@ out:
aio_context_release(aio_context);
}
-#define DEFAULT_MIRROR_BUF_SIZE (10 << 20)
-
void qmp_drive_mirror(const char *device, const char *target,
bool has_format, const char *format,
bool has_node_name, const char *node_name,
@@ -2682,7 +2680,7 @@ void qmp_drive_mirror(const char *device, const char *target,
granularity = 0;
}
if (!has_buf_size) {
- buf_size = DEFAULT_MIRROR_BUF_SIZE;
+ buf_size = 0;
}
if (!has_unmap) {
unmap = true;