summaryrefslogtreecommitdiff
path: root/exec.c
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2015-07-20 12:27:16 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2015-07-23 07:37:38 +0200
commit0b8e2c1002afddc8ef3d52fa6fc29e4768429f98 (patch)
tree9b8bb89a039327032c84e624a726fe3633b318c7 /exec.c
parentdc94bd9166af5236a56bd5bb06845911915a925c (diff)
downloadqemu-0b8e2c1002afddc8ef3d52fa6fc29e4768429f98.tar.gz
exec.c: Use atomic_rcu_read() to access dispatch in memory_region_section_get_iotlb()
When accessing the dispatch pointer in an AddressSpace within an RCU critical section we should always use atomic_rcu_read(). Fix an access within memory_region_section_get_iotlb() which was incorrectly doing a direct pointer access. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <1437391637-31576-1-git-send-email-peter.maydell@linaro.org> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'exec.c')
-rw-r--r--exec.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/exec.c b/exec.c
index 7d60e1530c..0a4a0c5af6 100644
--- a/exec.c
+++ b/exec.c
@@ -954,7 +954,10 @@ hwaddr memory_region_section_get_iotlb(CPUState *cpu,
iotlb |= PHYS_SECTION_ROM;
}
} else {
- iotlb = section - section->address_space->dispatch->map.sections;
+ AddressSpaceDispatch *d;
+
+ d = atomic_rcu_read(&section->address_space->dispatch);
+ iotlb = section - d->map.sections;
iotlb += xlat;
}