diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2017-02-16 17:26:48 +0000 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2017-02-28 09:03:39 +0300 |
| commit | 3d74ee7dcae57b93a64737b954d76cf96236a367 (patch) | |
| tree | 0b9e13fab998381581653d694651185de41bfd27 /hw/display | |
| parent | 79cad2faace2175f2f21dc4f8f40c3b7722cf999 (diff) | |
| download | qemu-3d74ee7dcae57b93a64737b954d76cf96236a367.tar.gz | |
lm32: milkymist-tmu2: fix a third integer overflow
Don't truncate the multiplication and do a 64 bit one instead
because the result is stored in a 64 bit variable.
This fixes a similar coverity warning to commits 237a8650d640 and
4382fa655498, in a similar way, and is the final third of the fix for
coverity CID 1167561 (hopefully!).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Michael Walle <michael@walle.cc>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'hw/display')
| -rw-r--r-- | hw/display/milkymist-tmu2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/display/milkymist-tmu2.c b/hw/display/milkymist-tmu2.c index 7528665510..59120ddb67 100644 --- a/hw/display/milkymist-tmu2.c +++ b/hw/display/milkymist-tmu2.c @@ -293,7 +293,7 @@ static void tmu2_start(MilkymistTMU2State *s) cpu_physical_memory_unmap(mesh, mesh_len, 0, mesh_len); /* Write back the OpenGL framebuffer to the QEMU framebuffer */ - fb_len = 2 * s->regs[R_DSTHRES] * s->regs[R_DSTVRES]; + fb_len = 2ULL * s->regs[R_DSTHRES] * s->regs[R_DSTVRES]; fb = cpu_physical_memory_map(s->regs[R_DSTFBUF], &fb_len, 1); if (fb == NULL) { glDeleteTextures(1, &texture); |