diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2014-03-24 21:47:05 +0100 |
|---|---|---|
| committer | Peter Wu <peter@lekensteyn.nl> | 2014-03-24 21:47:05 +0100 |
| commit | 9cccf4cf2206a7ab4ebb75bd9ba87ec8a9d33328 (patch) | |
| tree | 4da282a7fdbcd64f054b391900071e39ede07882 /hw/usb/hid-logitech-dj.c | |
| parent | f0a5825c53db1f659f897eec62506f7763ee6280 (diff) | |
| download | qemu-9cccf4cf2206a7ab4ebb75bd9ba87ec8a9d33328.tar.gz | |
unifying: mouse compat with Win guests, other mouse fixes
Two stupid mistakes slipped in while refactoring the HID report
generation in 3615170bd1ed6f09f878a8b538321044efddd8e0 ("unifying: fix
mouse report format, DRY"). This makes evtest in Linux report mouse
events again and openbox seems happy too.
Another mistake went in the calculation of the Y field, the high and
low bits of Y were accidentally swapped.
As the descriptor for interface 2 (mouse, etc.) includes Report IDs,
this ID must be prepended to the HID payload for mice reports. This
makes the mouse function for Windows guests. (See section 8.1 of
HID 1.11).
Signed-off-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'hw/usb/hid-logitech-dj.c')
| -rw-r--r-- | hw/usb/hid-logitech-dj.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/usb/hid-logitech-dj.c b/hw/usb/hid-logitech-dj.c index 5f1bc80f56..bc293a2dc5 100644 --- a/hw/usb/hid-logitech-dj.c +++ b/hw/usb/hid-logitech-dj.c @@ -493,7 +493,7 @@ static void hidpp_handle_hid(USBDevice *dev, USBPacket *p) } if (usb_ltunify_poll_hid(hd->hid, hid_data, sizeof(msg.payload)) <= 0) { - return; + continue; } msg.device_index = i + 1; |