diff options
| author | Ronnie Sahlberg <ronniesahlberg@gmail.com> | 2012-07-12 16:52:47 +1000 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2012-07-26 17:44:10 +0200 |
| commit | ba6095cd6b497783e3621606b6b2320781aa3f52 (patch) | |
| tree | d568335833a272c74a7d5a01a653be40d2085c32 /hw | |
| parent | 96bdbbab55976b106f9db2b61042ebf5f0493e5a (diff) | |
| download | qemu-ba6095cd6b497783e3621606b6b2320781aa3f52.tar.gz | |
scsi-disk: improve the lba-out-of-range tests for read/write/verify
Improve the tests for the LBA to cover more cases.
For the 16 byte opcodes, the lba is a uint64, so we need to check is to
make sure that we do not wrap. For example if an opcode would specify
the LBA:0xffffffffffffffff and LEN:2 then lba+len would wrap to 1.
Also verify that ALL requested blocks are available, not just the first one.
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/scsi-disk.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 526da4b4fc..3c03159c1f 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -1777,7 +1777,8 @@ static int32_t scsi_disk_dma_command(SCSIRequest *req, uint8_t *buf) if (r->req.cmd.buf[1] & 0xe0) { goto illegal_request; } - if (r->req.cmd.lba > s->qdev.max_lba) { + if (r->req.cmd.lba > r->req.cmd.lba + len || + r->req.cmd.lba + len - 1 > s->qdev.max_lba) { goto illegal_lba; } r->sector = r->req.cmd.lba * (s->qdev.blocksize / 512); @@ -1800,7 +1801,8 @@ static int32_t scsi_disk_dma_command(SCSIRequest *req, uint8_t *buf) if (r->req.cmd.buf[1] & 0xe0) { goto illegal_request; } - if (r->req.cmd.lba > s->qdev.max_lba) { + if (r->req.cmd.lba > r->req.cmd.lba + len || + r->req.cmd.lba + len - 1 > s->qdev.max_lba) { goto illegal_lba; } r->sector = r->req.cmd.lba * (s->qdev.blocksize / 512); |