diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2011-07-04 14:43:58 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2011-07-05 11:23:43 +0200 |
| commit | c925400ba83bd57bf560e071f400012248f1644a (patch) | |
| tree | 84971e38b8c5f5c212f6cfb35fe46e14e0f972c7 /hw | |
| parent | 40c4ed3f95f0b2ffa0848df0fc311556bb7472a1 (diff) | |
| download | qemu-c925400ba83bd57bf560e071f400012248f1644a.tar.gz | |
ide: Initialise buffers with zeros
Just in case there's still a way how a guest can read out buffers when it's not
supposed to, let's zero the buffers during initialisation so that we don't leak
information to the guest.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/ide/core.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/hw/ide/core.c b/hw/ide/core.c index a29ae9fb90..d145b19b0c 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1789,9 +1789,13 @@ static void ide_init1(IDEBus *bus, int unit) s->unit = unit; s->drive_serial = drive_serial++; /* we need at least 2k alignment for accessing CDROMs using O_DIRECT */ - s->io_buffer = qemu_memalign(2048, IDE_DMA_BUF_SECTORS*512 + 4); s->io_buffer_total_len = IDE_DMA_BUF_SECTORS*512 + 4; + s->io_buffer = qemu_memalign(2048, s->io_buffer_total_len); + memset(s->io_buffer, 0, s->io_buffer_total_len); + s->smart_selftest_data = qemu_blockalign(s->bs, 512); + memset(s->smart_selftest_data, 0, 512); + s->sector_write_timer = qemu_new_timer_ns(vm_clock, ide_sector_write_timer_cb, s); } |