summaryrefslogtreecommitdiff
path: root/include/hw/i386
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2013-06-16 18:31:30 +0300
committerMichael S. Tsirkin <mst@redhat.com>2013-07-04 10:42:51 +0300
commitbc3e6a0d6c8ab6cd7cd4b576ed567756f1dcabd2 (patch)
tree305b2b9b6790c6228f292bb43f3a566cecda513d /include/hw/i386
parentc6d559d9cf8687d8378e888e7570c07ce53b94e2 (diff)
downloadqemu-bc3e6a0d6c8ab6cd7cd4b576ed567756f1dcabd2.tar.gz
pvpanic: initialization cleanup
Avoid use of static variables: PC systems initialize pvpanic device through pvpanic_init, so we can simply create the fw_cfg file at that point. This also makes it possible to skip device creation completely if fw_cfg is not there, e.g. for xen - so the ports it reserves are not discoverable by guests. Also, make pvpanic_init void since callers ignore return status anyway. Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Paul Durrant <Paul.Durrant@citrix.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include/hw/i386')
-rw-r--r--include/hw/i386/pc.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index dbdd523561..5949e7ec5f 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -193,7 +193,7 @@ static inline bool isa_ne2000_init(ISABus *bus, int base, int irq, NICInfo *nd)
void pc_system_firmware_init(MemoryRegion *rom_memory);
/* pvpanic.c */
-int pvpanic_init(ISABus *bus);
+void pvpanic_init(ISABus *bus);
/* e820 types */
#define E820_RAM 1