diff options
| author | Denis V. Lunev <den@openvz.org> | 2015-11-19 09:42:01 +0300 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2015-11-19 11:50:00 +0100 |
| commit | e9ff957ac26e0e11869a3568cfa7423ae33c51e7 (patch) | |
| tree | 202f78903d148296e9bd8a86814b47e10426816e /migration | |
| parent | 5df5416e639cd75bd85d243af41387c2418fa580 (diff) | |
| download | qemu-e9ff957ac26e0e11869a3568cfa7423ae33c51e7.tar.gz | |
snapshot: create helper to test that block drivers supports snapshots
The patch enforces proper locking for this operation.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
Tested-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/savevm.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/migration/savevm.c b/migration/savevm.c index d90e228568..4646aa1178 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1958,19 +1958,10 @@ void hmp_savevm(Monitor *mon, const QDict *qdict) const char *name = qdict_get_try_str(qdict, "name"); Error *local_err = NULL; - /* Verify if there is a device that doesn't support snapshots and is writable */ - bs = NULL; - while ((bs = bdrv_next(bs))) { - - if (!bdrv_is_inserted(bs) || bdrv_is_read_only(bs)) { - continue; - } - - if (!bdrv_can_snapshot(bs)) { - monitor_printf(mon, "Device '%s' is writable but does not support snapshots.\n", - bdrv_get_device_name(bs)); - return; - } + if (!bdrv_all_can_snapshot(&bs)) { + monitor_printf(mon, "Device '%s' is writable but does not " + "support snapshots.\n", bdrv_get_device_name(bs)); + return; } bs = find_vmstate_bs(); |