diff options
| author | Stefan Weil <sw@weilnetz.de> | 2012-09-03 22:13:56 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2012-09-12 15:50:09 +0200 |
| commit | 1e53537fdaa4657d11f130a0f2673fcfb1956381 (patch) | |
| tree | 09f2dec1dd35f40e3d919eed881d09e17fab8674 /qapi-schema-guest.json | |
| parent | ce560dcf20c14194db5ef3b9fc1ea592d4e68109 (diff) | |
| download | qemu-1e53537fdaa4657d11f130a0f2673fcfb1956381.tar.gz | |
ide: Fix error messages from static code analysis (no real error)
Report from smatch:
hw/ide/core.c:1472 ide_exec_cmd(423) error: buffer overflow 'smart_attributes' 8 <= 29
hw/ide/core.c:1474 ide_exec_cmd(425) error: buffer overflow 'smart_attributes' 8 <= 29
hw/ide/core.c:1475 ide_exec_cmd(426) error: buffer overflow 'smart_attributes' 8 <= 29
...
The upper limit of 30 was never reached because both for loops terminated
when 'smart_attributes' reached end of list, so there was no real buffer
overflow.
Nevertheless, changing the code not only fixes the error report, but also
reduces the size of smart_attributes and simplifies the for loops.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'qapi-schema-guest.json')
0 files changed, 0 insertions, 0 deletions