diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2016-06-23 14:20:24 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2016-09-05 19:06:47 +0200 |
| commit | 75dfd402a734e8080fa77a1bcf60ecc46e0e6158 (patch) | |
| tree | 39eae6d094df6f480001718b0c8b7a0a5d64d0d1 /qapi | |
| parent | 2dfb4c033f2f8fbad252bed1ba3e0fed112cbb7c (diff) | |
| download | qemu-75dfd402a734e8080fa77a1bcf60ecc46e0e6158.tar.gz | |
block: Accept node-name for blockdev-snapshot-internal-sync
In order to remove the necessity to use BlockBackend names in the
external API, we want to allow node-names everywhere. This converts
blockdev-snapshot-internal-sync to accept a node-name without lifting
the restriction that we're operating at a root node.
In case of an invalid device name, the command returns the GenericError
error class now instead of DeviceNotFound, because this is what
qmp_get_root_bs() returns.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'qapi')
| -rw-r--r-- | qapi/block.json | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/qapi/block.json b/qapi/block.json index c0e831fd29..db05169187 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -58,7 +58,8 @@ ## # @BlockdevSnapshotInternal # -# @device: the name of the device to generate the snapshot from +# @device: the device name or node-name of a root node to generate the snapshot +# from # # @name: the name of the internal snapshot to be created # @@ -80,7 +81,7 @@ # For the arguments, see the documentation of BlockdevSnapshotInternal. # # Returns: nothing on success -# If @device is not a valid block device, DeviceNotFound +# If @device is not a valid block device, GenericError # If any snapshot matching @name exists, or @name is empty, # GenericError # If the format of the image used does not support it, |