diff options
| author | Markus Armbruster <armbru@redhat.com> | 2017-03-03 13:32:31 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2017-03-05 09:14:19 +0100 |
| commit | 910f738b851a263396fc85b2052e47f884ffead3 (patch) | |
| tree | 9565ed5e772adbaf177af1ec82a227867dc7eb51 /qapi | |
| parent | 99fb0c53c038105bae68b02a3d9f1cbf7951ba10 (diff) | |
| download | qemu-910f738b851a263396fc85b2052e47f884ffead3.tar.gz | |
qapi: Improve a QObject input visitor error message
The QObject input visitor has three error message formats:
* Parameter '%s' is missing
* "Invalid parameter type for '%s', expected: %s"
* "QMP input object member '%s' is unexpected"
The '%s' are member names (or "null", but I'll fix that later).
The last error message calls the thing "QMP input object member"
instead of "parameter". Misleading when the visitor is used on
QObjects that don't come from QMP. Change it to "Parameter '%s' is
unexpected".
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1488544368-30622-12-git-send-email-armbru@redhat.com>
Diffstat (limited to 'qapi')
| -rw-r--r-- | qapi/qobject-input-visitor.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c index ed6c24ca44..f3b6713f94 100644 --- a/qapi/qobject-input-visitor.c +++ b/qapi/qobject-input-visitor.c @@ -140,8 +140,7 @@ static void qobject_input_check_struct(Visitor *v, Error **errp) g_hash_table_iter_init(&iter, top_ht); if (g_hash_table_iter_next(&iter, (void **)&key, NULL)) { - error_setg(errp, "QMP input object member '%s' is unexpected", - key); + error_setg(errp, "Parameter '%s' is unexpected", key); } } } |