summaryrefslogtreecommitdiff
path: root/savevm.c
diff options
context:
space:
mode:
authorDr. David Alan Gilbert <dgilbert@redhat.com>2014-02-12 17:20:10 +0000
committerMichael Roth <mdroth@linux.vnet.ibm.com>2014-06-26 14:12:33 -0500
commita2b4e846b350f78fcb737195a40c5900923d5be8 (patch)
tree94897f39af796fa9220c98b0e5cc539918dfd167 /savevm.c
parentf217f379a8ce520cce1e905c33660ca5a7ecad1c (diff)
downloadqemu-a2b4e846b350f78fcb737195a40c5900923d5be8.tar.gz
Fix vmstate_info_int32_le comparison/assign
Fix comparison of vmstate_info_int32_le so that it succeeds if loaded value is (l)ess than or (e)qual When the comparison succeeds, assign the value loaded This is a change in behaviour but I think the original intent, since the idea is to check if the version/size of the thing you're loading is less than some limit, but you might well want to do something based on the actual version/size in the file Fix up comment and name text Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com> (cherry picked from commit 24a370ef2351dc596a7e47508b952ddfba79ef94) Conflicts: vmstate.c *removed dependency on b6fcfa59 (Move VMState code to vmstate.c) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'savevm.c')
-rw-r--r--savevm.c16
1 files changed, 9 insertions, 7 deletions
diff --git a/savevm.c b/savevm.c
index 8a228070dc..40054cfbe3 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1111,22 +1111,24 @@ const VMStateInfo vmstate_info_int32_equal = {
.put = put_int32,
};
-/* 32 bit int. See that the received value is the less or the same
- than the one in the field */
+/* 32 bit int. Check that the received value is less than or equal to
+ the one in the field */
static int get_int32_le(QEMUFile *f, void *pv, size_t size)
{
- int32_t *old = pv;
- int32_t new;
- qemu_get_sbe32s(f, &new);
+ int32_t *cur = pv;
+ int32_t loaded;
+ qemu_get_sbe32s(f, &loaded);
- if (*old <= new)
+ if (loaded <= *cur) {
+ *cur = loaded;
return 0;
+ }
return -EINVAL;
}
const VMStateInfo vmstate_info_int32_le = {
- .name = "int32 equal",
+ .name = "int32 le",
.get = get_int32_le,
.put = put_int32,
};