diff options
| author | Andreas Färber <afaerber@suse.de> | 2013-05-10 16:34:06 +0200 |
|---|---|---|
| committer | Andreas Färber <afaerber@suse.de> | 2013-07-09 21:20:28 +0200 |
| commit | 6e42be7cd10260fd3a006d94f6c870692bf7a2c0 (patch) | |
| tree | 75a590145a887c9d8424fd100d23e985ce2338ae /target-m68k | |
| parent | 6291ad77d7c57dfc52a6a938d1a77ec3ec3ad16c (diff) | |
| download | qemu-6e42be7cd10260fd3a006d94f6c870692bf7a2c0.tar.gz | |
cpu: Drop unnecessary dynamic casts in *_env_get_cpu()
A transition from CPUFooState to FooCPU can be considered safe,
just like FooCPU::env access in the opposite direction.
The only benefit of the FOO_CPU() casts would be protection against
bogus CPUFooState pointers, but then surrounding code would likely
break, too.
This should slightly improve interrupt etc. performance when going from
CPUFooState to FooCPU.
For any additional CPU() casts see 3556c233d931ad5ffa46a35cb25cfc057732ebb8
(qom: allow turning cast debugging off).
Reported-by: Anthony Liguori <aliguori@us.ibm.com>
Acked-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'target-m68k')
| -rw-r--r-- | target-m68k/cpu-qom.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target-m68k/cpu-qom.h b/target-m68k/cpu-qom.h index 2436c13c5c..858bf30088 100644 --- a/target-m68k/cpu-qom.h +++ b/target-m68k/cpu-qom.h @@ -63,7 +63,7 @@ typedef struct M68kCPU { static inline M68kCPU *m68k_env_get_cpu(CPUM68KState *env) { - return M68K_CPU(container_of(env, M68kCPU, env)); + return container_of(env, M68kCPU, env); } #define ENV_GET_CPU(e) CPU(m68k_env_get_cpu(e)) |