diff options
| author | Nathan Froyd <froydnj@codesourcery.com> | 2010-10-29 07:48:46 -0700 |
|---|---|---|
| committer | Aurelien Jarno <aurelien@aurel32.net> | 2010-12-22 11:14:10 +0100 |
| commit | 9ed5726c043958359b0f1fa44ab3e4f25f9d9a47 (patch) | |
| tree | 929a689c59a4d6ef902924b77181f2165caf09c0 /target-mips/helper.h | |
| parent | cbb608a5c8ff918188545edb28127f63db76bd1e (diff) | |
| download | qemu-9ed5726c043958359b0f1fa44ab3e4f25f9d9a47.tar.gz | |
target-mips: fix translation of MT instructions
The translation of dmt/emt/dvpe/evpe was doing the moral equivalent of:
int x;
... /* no initialization of x */
x = f (x);
which confused later bits of TCG rather badly, leading to crashes.
Fix the helpers to only return results (those instructions have no
inputs), and fix the translation code accordingly.
Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Diffstat (limited to 'target-mips/helper.h')
| -rw-r--r-- | target-mips/helper.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/target-mips/helper.h b/target-mips/helper.h index cb13fb2352..297ab64bda 100644 --- a/target-mips/helper.h +++ b/target-mips/helper.h @@ -154,10 +154,10 @@ DEF_HELPER_2(mttlo, void, tl, i32) DEF_HELPER_2(mtthi, void, tl, i32) DEF_HELPER_2(mttacx, void, tl, i32) DEF_HELPER_1(mttdsp, void, tl) -DEF_HELPER_1(dmt, tl, tl) -DEF_HELPER_1(emt, tl, tl) -DEF_HELPER_1(dvpe, tl, tl) -DEF_HELPER_1(evpe, tl, tl) +DEF_HELPER_0(dmt, tl) +DEF_HELPER_0(emt, tl) +DEF_HELPER_0(dvpe, tl) +DEF_HELPER_0(evpe, tl) #endif /* !CONFIG_USER_ONLY */ /* microMIPS functions */ |