summaryrefslogtreecommitdiff
path: root/target-mips
diff options
context:
space:
mode:
authorPetar Jovanovic <petarj@mips.com>2012-11-26 16:13:21 +0100
committerMichael Roth <mdroth@linux.vnet.ibm.com>2013-01-14 15:42:38 -0600
commit16c5fe49de2be4aedf8cce30df924a5aadd0d9a1 (patch)
treef0952603193f7125864cd2c1d8f4a3f3bac84952 /target-mips
parentf1a2195ec327fd2b837a3539623ee431d133f03c (diff)
downloadqemu-16c5fe49de2be4aedf8cce30df924a5aadd0d9a1.tar.gz
target-mips: Fix incorrect code and test for INSV
Content of register rs should be shifted for pos before applying a mask. This change contains both fix for the instruction and to the existing test. Signed-off-by: Petar Jovanovic <petarj@mips.com> Reviewed-by: Eric Johnson <ericj@mips.com> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> (cherry picked from commit 34f5606ee101f82a247d09d05644ad2a63c8e342) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'target-mips')
-rw-r--r--target-mips/dsp_helper.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
index e7949c22c0..fda5f0460b 100644
--- a/target-mips/dsp_helper.c
+++ b/target-mips/dsp_helper.c
@@ -3152,7 +3152,7 @@ target_ulong helper_##name(CPUMIPSState *env, target_ulong rs, \
\
filter = ((int32_t)0x01 << size) - 1; \
filter = filter << pos; \
- temprs = rs & filter; \
+ temprs = (rs << pos) & filter; \
temprt = rt & ~filter; \
temp = temprs | temprt; \
\